fix(ratewise): 收斂首頁換算器 CLS 固定高度（#454）#486
Merged
Merged
Conversation
- SingleConverter 匯率卡片與 pill 槽位預留 min-height，移除趨勢圖 translate 進場 - RateWise 資料來源 footer 保留 min-h-6 避免載入後位移 - 補 design-tokens SSOT 與 core 測試 測試：pnpm --filter @app/ratewise exec vitest run SingleConverter.core.test.tsx Co-authored-by: Cursor <cursoragent@cursor.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/Lighthouse CLS=0.237 超標（門檻 ≤0.1）SingleConverter匯率卡片新增cardMinHeight/rateTextBlock/rateBasisSlotSSOT token，預留 feat(ratewise): 收編金融級計價基準 SSOT 與計算機即時換算預覽 #441 計價基準 pill 槽位translate-y進場動畫，圖表容器自初始渲染起固定高度可見RateWise資料來源 footer 改為永遠渲染並保留min-h-6，避免載入完成後位移關聯
Test plan
pnpm --filter @app/ratewise exec vitest run SingleConverter.core.test.tsxMade with Cursor