fix(ratewise): 修復窄視窗 QA 佈局重疊與觸控目標#494
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
4 tasks
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
- 360×800：main 底部留白 +28px，避免 CTA 與 bottom nav 重疊 - 320×568：infoPadding 頂部 pt-10，避免匯率文字蓋住 RateSelector - 加入歷史 CTA：micro/nano 套用 min-h-11（WCAG 44px） - 新增 design-tokens / AppLayout 防回歸測試 測試：typecheck；design-tokens、AppLayout.safe-area、SingleConverter.core（67 passed） Co-authored-by: Cursor <cursoragent@cursor.com>
s123104
force-pushed
the
fix/viewport-qa-layout-hotfix
branch
from
54d9ef9 to
04ed55f
Compare
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
navigationTokens.mainScroll在≤360px額外 +28px bottom padding，避免「加入歷史」CTA 與 fixed bottom nav 重疊singleConverterLayoutTokens.rateCard.infoPadding頂部改pt-10（40px），避免匯率文字與絕對定位 RateSelector 重疊addToHistorytoken 在 micro/nano 套用min-h-11（44px），符合 WCAG 2.2 最小觸控尺寸Root cause
QA 10 裝置矩陣實測缺陷，非 band-aid：
infoPadding過激（pt-5/pt-4），RateSelector 絕對定位於卡片頂部，匯率大字向下侵入py-1.5使 CTA 實測高度 ~38px，低於 44px 觸控下限Changed files
apps/ratewise/src/config/design-tokens.tsapps/ratewise/src/components/AppLayout.tsxapps/ratewise/src/config/design-tokens.test.tsapps/ratewise/src/components/__tests__/AppLayout.safe-area.test.tsx.changeset/viewport-qa-layout-hotfix.mddocs/dev/002_development_reward_penalty_log.mdTest plan
pnpm --filter @app/ratewise typecheckpnpm --filter @app/ratewise test -- design-tokens.test AppLayout.safe-area SingleConverter.core（67 passed）typecheck+test+build:ratewiseNotes
cardMinHeight，避免首頁 CLS 回歸；優先以 padding SSOT 修正Made with Cursor