fix(publish): remove --abi3/--interpreter flags; abi3 via Cargo.toml feature#45
Merged
Conversation
…feature WHAT: maturin-action v1 does not accept `--abi3` as a standalone CLI flag (maturin itself requires a value: `--abi3 <PY_VERSION>` is not a valid form either — abi3 is activated by PyO3's `abi3-py39` CRATE FEATURE, not a CLI flag). The original workflow passed `--interpreter python3.11 --abi3` which maturin rejected with "tip: to pass '--abi3' as a value, use '-- --abi3'". FIX: Drop `--interpreter` and `--abi3` from the `args:` lines entirely. `abi3-py39` is already declared in `Cargo.toml`'s pyo3 features; maturin detects it automatically and stamps the wheel `cp39-abi3`. Also move `MATURIN_PYPI_TOKEN` into the upload step env (not a global env) — the token is only needed by `maturin upload`, not the build steps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018R92DDLCsWorb4fSJQrdvD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The publish workflow failed with:
maturin-actionv1 was being passed--interpreter python3.11 --abi3inargs:, which maturin doesn't accept — abi3 is activated by thepyo3/abi3-py39crate feature inCargo.toml, not a CLI flag.Fix
Drop
--interpreterand--abi3from all three wheel jobs'args:. Theabi3-py39feature is already declared inCargo.toml; maturin auto-detects it and stamps wheelscp39-abi3. Also scopedMATURIN_PYPI_TOKENto just the upload step (not global env).After merge
Re-push the
v0.1.0tag to re-trigger the publish run:risk:low — workflow-only change, no Rust code modified