Handle file rename in .cabal file - #4961
Open
VeryMilkyJoe wants to merge 2 commits into
Open
Conversation
VeryMilkyJoe
force-pushed
the
rename-file-cabal
branch
from
July 12, 2026 10:35
f01a8c6 to
f939273
Compare
On WillRename Notification, edit the responsible .cabal file to change the module name entry of the renamed module to the new name.
VeryMilkyJoe
force-pushed
the
rename-file-cabal
branch
from
July 12, 2026 11:31
f939273 to
cfbbef1
Compare
VeryMilkyJoe
force-pushed
the
rename-file-cabal
branch
2 times, most recently
from
August 6, 2026 17:55
f5de604 to
4eece12
Compare
dyniec
approved these changes
Aug 6, 2026
dyniec
left a comment
dyniec
left a comment
Collaborator
There was a problem hiding this comment.
rename yay!
Looks fine,and tests seem alright. Should be fine to merge when CI succeeds
Aster89
reviewed
Aug 6, 2026
Aster89
left a comment
Aster89
left a comment
Contributor
There was a problem hiding this comment.
Love this!
Some newbie comments below 😆
VeryMilkyJoe
force-pushed
the
rename-file-cabal
branch
3 times, most recently
from
August 6, 2026 19:49
3d311bb to
2cce790
Compare
AndreasPK
reviewed
Aug 6, 2026
VeryMilkyJoe
force-pushed
the
rename-file-cabal
branch
from
August 6, 2026 20:03
2cce790 to
06f6ad0
Compare
AndreasPK
reviewed
Aug 6, 2026
| runActionE "cabalAdd.getVersionedTextDoc" ideState $ | ||
| lift $ | ||
| getVersionedTextDoc $ | ||
| TextDocumentIdentifier (filePathToUri cabalFilePath) |
Collaborator
Author
There was a problem hiding this comment.
No, it takes a Uri as defined by the type of TextDocumentIdentifier.
VeryMilkyJoe
force-pushed
the
rename-file-cabal
branch
from
August 6, 2026 20:14
06f6ad0 to
bc3ab5f
Compare
AndreasPK
reviewed
Aug 6, 2026
| Maybe.maybe [] exposedModules $ library pd | ||
| LSubLibName _ -> | ||
| concat $ Maybe.concatMapM (getExposedModulesForLib compName) $ subLibraries pd | ||
| _ -> [] |
There was a problem hiding this comment.
Suggested change
| _ -> [] | |
| CNotLibName -> ? |
I think executables can have other-modules and need to be handled here but not 100% sure.
Collaborator
Author
There was a problem hiding this comment.
This is handled later on, the first part here checks only whether the module is in exposed modules if it occurs, since there are more limited cases for this.
If the module still occurs in a field but was not in an exposed module then it has to be in other modules, which would cover the case you proposed.
I changed the code a bit to hopefully improve readability.
VeryMilkyJoe
force-pushed
the
rename-file-cabal
branch
2 times, most recently
from
August 6, 2026 20:39
80a48ef to
50250f1
Compare
fendor
reviewed
Aug 6, 2026
fendor
reviewed
Aug 6, 2026
VeryMilkyJoe
force-pushed
the
rename-file-cabal
branch
2 times, most recently
from
August 9, 2026 12:01
9546635 to
584441e
Compare
VeryMilkyJoe
force-pushed
the
rename-file-cabal
branch
from
August 9, 2026 12:20
584441e to
32e0eb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a
WillRenameFileNotification, we find the responsible.cabalfile for the old filepath and replace the corresponding module path with the module path for the new file name.This is part of the implementation of #4951.
In the next PR, I will propagate the rename in Haskell files, i.e. rename in module declaration and imports.
Screencast.From.2026-06-08.10-19-12.mp4