Some improvements of comments, of code, and return->pure - #5026
Merged
Conversation
fendor
requested changes
Jul 26, 2026
fendor
left a comment
fendor
left a comment
Collaborator
There was a problem hiding this comment.
Some small comments.
Generally, we don't really do these kinds of refactorings of return -> pure unless there is a real incentive.
We don't do this because occasionally, the code in question is directly copied from GHC, changing it just diverges from the original sources, making it harder to see that.
This time, I think it is fine.
Perhaps we should create a style guide for HLS 🤔
fendor
reviewed
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes, hopefully improvements, I made while working on #5014:
returntopurein a file I passed by,EpToken, considering it only has 2 ctors,addMethodDecls's signature and a piece of the implemention simpler for GHC ≥ 9.10.