Skip to content

[Performance] Run refresh work in the existing force runner - #5039

Open
soulomoon wants to merge 3 commits into
haskell:masterfrom
soulomoon:codex/remove-redundant-refresh-async
Open

[Performance] Run refresh work in the existing force runner#5039
soulomoon wants to merge 3 commits into
haskell:masterfrom
soulomoon:codex/remove-redundant-refresh-async

Conversation

@soulomoon

@soulomoon soulomoon commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Run refresh work directly in the existing force runner, removing the redundant asyncWithCleanUp layer and its extra async registration and wait. Notice we already have data Wait to handle possible thread spawning. We have 5% perf improvement with this simple deletion

@soulomoon soulomoon added the performance Issues about memory consumption, responsiveness, etc. label Aug 11, 2026
@soulomoon
soulomoon marked this pull request as ready for review August 11, 2026 22:17
@soulomoon
soulomoon requested a review from wz1000 as a code owner August 11, 2026 22:17
@soulomoon

soulomoon commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

here is the perf report from codex gather from the pipeline:

Performance report

Benchmarked exact head b2037b82f1 against master 16bf046629.

Metric Result versus master
Geometric-mean totalT −6.11%
Summed totalT −4.78%
Median totalT −4.42%
Faster benchmark cases 78 of 85

Results by configuration

Configuration Geometric-mean totalT Summed totalT Median
Cabal, GHC 9.12 −4.17% −3.95% −2.27%
Cabal, GHC 9.14 −9.40% −7.97% −10.34%
lsp-types, GHC 9.12 −6.63% −4.29% −5.46%
lsp-types, GHC 9.14 −4.26% −3.60% −4.03%

code actions after cradle edit

Configuration Result versus master
GHC 9.12 −6.30%
GHC 9.14 −4.96%

Conclusion: b2037b82f1 is faster than master across the benchmark suite, improving 78 of 85 successful benchmark cases.

@soulomoon soulomoon changed the title Run refresh work in the existing force runner [Performance] Run refresh work in the existing force runner Aug 12, 2026
@soulomoon
soulomoon requested a review from fendor August 13, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: hls-graph performance Issues about memory consumption, responsiveness, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant