🧪 [testing improvement] Abstract SMAppService to enable testing for registerLoginItem error paths

[hatimhtm]

🧪 [testing improvement] Abstract SMAppService to enable testing for registerLoginItem error paths

🎯 What

The registerLoginItem method in AppDelegate.swift previously had a hardcoded dependency on the SMAppService.mainApp singleton. This tightly coupled design made it difficult to unit test the error path (the catch block) and the conditional path handling existing login items.

📊 Coverage

By extracting the login item registration behavior into an AppServiceProtocol and using dependency injection, we can introduce a MockAppService in our tests. The new tests now cover:

• Happy Path: Registration when the service is not currently enabled.
• Already Enabled Path: Verification that the app unregisters before re-registering if already enabled.
• Error Path: Ensuring the application gracefully catches exceptions when register() or unregister() fails (which was the previously missing coverage).

✨ Result

100% deterministic test coverage for the registerLoginItem function, catching errors without exposing failures or unhandled exceptions during setup, ultimately improving app reliability during launch.

---

PR created automatically by Jules for task 8794643896328371606 started by @hatimhtm

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.