Added if statement modification - #1
Open
oasissan wants to merge 8 commits into
Open
Conversation
haxsysgit
self-requested a review
September 9, 2023 17:09
haxsysgit
approved these changes
Sep 9, 2023
haxsysgit
left a comment
haxsysgit
left a comment
Owner
There was a problem hiding this comment.
Hi osama , thanks for the contribution but i don't think their is a html attribute like "if"
thanks for your contribution
edit handling urls
Author
|
Ok so basically there is no attribute called if that is the point I am targeting this attribute exactly to have no conflicts to other attributes. So you basically can add whatever attribute you want in HTML it won't throw any errors. |
edit handling urls
# Conflicts: # html2django/djangohtml.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
Modified the code to the following, every element that has attribute (if) will be wrapped in if statement with the value of the attribute is the condition.