fix: reject NaN/Inf --wait so the CLI cannot hang - #3
Merged
Conversation
hc-ui
marked this pull request as ready for review
August 26, 2026 10:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
argparsetype=floatacceptsnan/inf. The old<= 0check does not catchnan(nan <= 0is false), so--wait nanwas accepted and--wait infnever timed out.What
whoseport.waitarg.require_finite_waitand install it as the--waittype from package init.nan/inf/-infexiting 2.Tests
PYTHONPATH=src python3 -m pytest -q→ 105 passed, 2 skipped (Windows-only).Does not repeat host:port tokens or docker-proxy.exe advice.