revert: remove server-side PDF table export#239
Merged
Conversation
Removes the table Print button and the backend PDF rendering it relied on, along with the dependencies introduced for it. Frontend: - Delete TableExportButton and the tableExport util. - Drop the button from the task and patient table toolbars. - Remove the now-unused 'print' translation key from every locale. Backend: - Delete the /export/table.pdf router and its unit tests. - Stop registering the export router in main.py. - Drop weasyprint and jinja2 from requirements and the Pango/fontconfig/font runtime libraries from the Dockerfile. Proxy: - Stop forwarding /export/* to the backend. The browser's native print view (Ctrl+P) is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the table Print button and the backend PDF rendering it relied on, plus all dependencies introduced for the feature (originally added in #232 / #235).
The browser's native print view (Ctrl+P) is a separate feature and is left untouched.
Changes
Frontend
TableExportButtonand thetableExportutil (downloadTablePdfetc.).printtranslation key from every locale (.arb+ generatedtranslations.ts).Backend
POST /export/table.pdfrouter and its unit tests.main.py.weasyprintandjinja2fromrequirements.txt.Dockerfile.Proxy
/export/*to the backend (revert the regex to^/(graphql|callback)$) and update the proxy README.Verification
check-translation-keys.mjs): all used keys exist in every locale..arbfiles remain valid JSON.backend/main.pycompiles; no remaining references to the export router.TableExportButton/tableExportin the web app.400 deletions; the only insertions are the small router-registration / import tidy-ups.
https://claude.ai/code/session_01Pz8wqwQhDmEKGpHayg8CPs
Generated by Claude Code