added a way to retry backups - #11
Open
ClaytonNorthey92 wants to merge 3 commits into
Open
Conversation
ClaytonNorthey92
force-pushed
the
clayton/upload-retries
branch
from
August 27, 2025 16:55
947152a to
5c7187b
Compare
ClaytonNorthey92
changed the title
ClaytonNorthey92
force-pushed
the
clayton/upload-retries
branch
from
August 27, 2025 19:30
5c7187b to
041ec2e
Compare
ClaytonNorthey92
changed the title
ClaytonNorthey92
marked this pull request as ready for review
August 27, 2025 19:35
joshuasing
reviewed
Aug 28, 2025
Contributor
Author
|
hey @joshuasing I believe I addressed all of your feedback, do you mind taking another look? |
* added flags --max-retries, --backoff-milliseconds for retrying with an exponential backoff * the flags apply to metadata and snapshots * changed the --keep-archives flag to default to true, so that a "null" value is true fixes #8
* using a duration variable instead of an int (ms) for backoff * removed extra newline
ClaytonNorthey92
force-pushed
the
clayton/upload-retries
branch
from
September 10, 2025 16:31
8e47084 to
ef9a7e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a way to retry backups
fixes #8