feat(config)!: load settings lazily via get_settings()#24
Merged
Conversation
Replace import-time GP_ACCESS_TOKEN snapshot with memoized get_settings() and ignore unknown env keys so shared .env files with Q2GOOGLE_* vars work. Co-authored-by: Cursor <cursoragent@cursor.com>
The action expects type_labels.breaking, not breaking_change. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GP_ACCESS_TOKENsnapshot with memoizedget_settings()so env and.envchanges are picked up aftercache_clear().extra="ignore"toSettingsso shared.envfiles withQ2GOOGLE_*variables no longer fail validation.GP_ACCESS_TOKENdirectly).Test plan
uv run gopro-api search --start 2026-01-01 --end 2026-01-02withGP_ACCESS_TOKENin.envGoProAPI()/AsyncGoProAPI()withoutaccess_tokenand confirm token resolves from envQ2GOOGLE_STATE_URI=...in.envalongsideGP_ACCESS_TOKENand confirm import no longer raisesMade with Cursor