fix(graph): normalize short parent filters - #209
Draft
bdarcus wants to merge 1 commit into
Draft
Conversation
Resolve --parent IDs through the same prefix normalization used by other bean commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BeanFilter.ParentIDthroughCore.NormalizeIDbeans list --parent <short-id>consistent withshowand relationship mutationsWhy
Parent links are stored with full IDs such as
beans-parent1, while the CLIaccepts short IDs such as
parent1elsewhere. The list filter compared thosestrings literally, so a valid short parent filter returned no children.
Validation
go test ./pkg/beangraph ./pkg/beancore ./internal/graphThe full suite is currently blocked by unrelated repository/environment issues:
missing
frontend/distembed assets, existing gitutil diff-format expectations,and a terminal environment timeout.