Skip to content

feat: tune crossplane resources and nodepool#19

Merged
patrickleet merged 1 commit into
mainfrom
feat/crossplane-resource-defaults-nodepool
May 25, 2026
Merged

feat: tune crossplane resources and nodepool#19
patrickleet merged 1 commit into
mainfrom
feat/crossplane-resource-defaults-nodepool

Conversation

@patrickleet
Copy link
Copy Markdown
Contributor

Summary:

  • Add explicit resource requests/limits for Crossplane, rbac-manager, providers, and function-auto-ready runtime.
  • Align runtime requests with current target-cluster Goldilocks/VPA recommendations.
  • Rename the default dedicated NodePool from crossplane to hops-crossplane.
  • Ensure Crossplane, providers, rbac-manager, and function-auto-ready use crossplane nodepool placement when nodePool is enabled.

Verification:

  • make test: 11/11 passed.
  • hops config install --path xrs/stacks/aws/crossplane --context colima: completed, package healthy.
  • Colima CrossplaneStack/default pat-local: Synced=True Ready=True.
  • Colima Helm Release crossplane: generation observed, Synced=True Ready=True, state=deployed, revision=4.
  • Colima runtime config Objects and nodepool Object: observed current generation, Synced=True Ready=True.
  • Target crossplane-system workloads: Crossplane, rbac-manager, providers, and function-auto-ready all 1/1 ready with explicit requests/limits matching this change.
  • Target scheduling: Crossplane, providers, rbac-manager, and function-auto-ready are on nodes labeled karpenter.sh/nodepool=hops-crossplane and workload-type=crossplane.
  • Target NodePools: hops-crossplane Ready with 2 nodes. The old crossplane NodePool still exists but has 0 nodes and no pods scheduled; this PR does not delete live orphaned infrastructure.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

Warning

Review limit reached

@patrickleet, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 1 review of capacity. Refill in 6 minutes and 29 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 68534e37-8b9b-4f63-a2ae-cccddc3e3e72

📥 Commits

Reviewing files that changed from the base of the PR and between 9eb0a2a and 0a75445.

📒 Files selected for processing (11)
  • apis/crossplanestacks/definition.yaml
  • functions/render/000-state-init.yaml.gotmpl
  • functions/render/100-crossplane-helm-release.yaml.gotmpl
  • functions/render/211-drc-aws.yaml.gotmpl
  • functions/render/213-provider-aws-sub-providers.yaml.gotmpl
  • functions/render/221-drc-kubernetes.yaml.gotmpl
  • functions/render/231-drc-helm.yaml.gotmpl
  • functions/render/241-drc-github.yaml.gotmpl
  • functions/render/250-functions.yaml.gotmpl
  • functions/render/270-drc-zitadel.yaml.gotmpl
  • tests/test-render/main.k
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/crossplane-resource-defaults-nodepool

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Published Crossplane Package

The following Crossplane package was published as part of this PR:

Package: ghcr.io/hops-ops/aws-crossplane-stack:pr-19-b4aa47b8796819973612e76f67c792988a2450f7

View Package

@patrickleet patrickleet merged commit 2b87541 into main May 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant