[codex] Treat loadmodule config as restart-only#31
Conversation
fcd05d7 to
56681fe
Compare
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56681fe624
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| directive := key | ||
| if i := strings.IndexAny(key, " \t"); i >= 0 { | ||
| directive = key[:i] | ||
| } | ||
| return restartKeys[directive] |
There was a problem hiding this comment.
Normalize restart-only directive names before lookup
For clusters whose spec.redis uses valid Redis config casing or leading whitespace, such as LoadModule /usr/local/lib/redis/modules/rejson.so, this keeps directive as LoadModule and the lookup returns false. The pod's generated redis.conf can still load that module at startup, but the instance reconciler will try to apply the same directive via live CONFIG SET on every reconcile instead of skipping it, reintroducing the failure this change is meant to avoid for those inputs. Trim and lowercase the directive before checking restartKeys.
Useful? React with 👍 / 👎.
Summary
loadmoduledirectives as restart-only config in the instance reconciler.loadmodule /path/to/module.sois handled correctly.loadmodulekeys with module arguments.0.2.3and add the changelog entry.Root Cause
spec.rediscan represent module loading directives as keys that include arguments, such asloadmodule /usr/local/lib/redis/modules/redistimeseries.so. The reconciler previously checked restart-only config with the full key string, so argument-bearingloadmoduledirectives were not recognized as restart-only and could be sent through liveCONFIG SETreconciliation.Validation
make testmake linthelm lint charts/redis-operator