Skip to content

25798: Improves reliability of docs rebuild pipeline - #620

Merged
apbassett merged 3 commits into
mainfrom
25798-rebuild-docs-flakey
Jul 28, 2026
Merged

25798: Improves reliability of docs rebuild pipeline#620
apbassett merged 3 commits into
mainfrom
25798-rebuild-docs-flakey

Conversation

@apbassett

Copy link
Copy Markdown
Member

No description provided.

@apbassett
apbassett requested review from a team as code owners July 27, 2026 21:10
@apbassett
apbassett enabled auto-merge (squash) July 27, 2026 21:35

@howso-mario howso-mario left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Hermes Agent. Verdict: comment / no blocking findings.

Evidence inspected: PR diff and repo guidance; status rollup for run 30305742261 (all build/smoke docs/final-check lanes green, release-only lanes skipped as expected); final-check log shows check-docs-commit, set-pr-version, build, and rebuild-docs all success; rebuild-docs log downloaded the ARM64 artifact and found no generated-doc changes; local git diff --check origin/main...HEAD was clean.

The final-check rewrite looks materially safer than the old required-check wrapper because it runs under always(), includes set-pr-version/build/rebuild-docs in needs, and requires exact success instead of treating skipped dependencies as acceptable. I left one inline non-blocking reliability hardening note for the docs-bot branch-movement window. No merge action taken.

Comment thread .github/workflows/rebuild-docs.yml Outdated

@howso-mario howso-mario left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at head f456598. Verified the docs rebuild workflow records the checked-out SHA, fetches and compares the live PR branch head before push, and exits successfully without pushing if the branch moved, addressing the prior reliability note. Inspected current diff and review thread inventory; no blocking findings remain. CI run 30369245810 is complete: required build, cross-platform smoke, rebuild-docs, and final-check lanes passed; release-only lanes were skipped as expected.

@apbassett
apbassett merged commit 119b978 into main Jul 28, 2026
24 checks passed
@apbassett
apbassett deleted the 25798-rebuild-docs-flakey branch July 28, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants