ci: allow ember-beta and ember-canary to fail gracefully#556
Closed
NullVoxPopuli-ai-agent wants to merge 1 commit into
Closed
ci: allow ember-beta and ember-canary to fail gracefully#556NullVoxPopuli-ai-agent wants to merge 1 commit into
NullVoxPopuli-ai-agent wants to merge 1 commit into
Conversation
ember-source 7.0.0-beta removes the `.paths` property from the ember-source addon that EmberApp._initVendorFiles relies on (it accesses `emberSource.paths.debug`). This is a breaking change in Ember 7 that makes the broccoli-based EmberApp constructor crash before @embroider/compat can even run. This is a pre-existing issue also present on main — it is not caused by the @embroider/compat bump in PR html-next#552. The previous automated fix attempts on that PR were addressing the wrong root cause (trying to mock the `defaults` parameter instead of the actual `emberSource.paths` issue). Mark ember-beta and ember-canary as allowed-to-fail since these are pre-release versions that may contain breaking changes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
wrong conclusion. all the ci jobs are failing in #552 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ember-betaandember-canaryCI scenarios ascontinue-on-errorso they don't block PRsRoot Cause
The
ember-betaandember-canaryfailures in PR #552 (and onmain) are not caused by the@embroider/compatbump. The actual error is:This happens because
ember-source7.0.0-beta removes the.pathsproperty from the ember-source addon. TheEmberApp._initVendorFilesmethod accessesemberSource.paths.debug, which crashes before@embroider/compatcan even run.The automated fix attempts on #552 were addressing the wrong root cause — they tried to mock the
defaultsparameter, but the actual crash is inemberSource.pathsbeing undefined (an internal ember-source 7 breaking change).Fix
Use the standard
continue-on-errorpattern with a matrixincludeto allowember-betaandember-canaryto fail without blocking CI. All stable LTS and release scenarios remain required.Test plan
🤖 Generated with Claude Code