Add official Apple Ads search popularity - #81
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AppleAdsClientSwift package and Search Term Popularity endpoint.envsupport for developmentWhy
The prior browser-session approach was not the same dataset and was unreliable. This change moves production popularity refreshes to Apple’s supported API/client and makes the source and unavailable-state semantics explicit.
Apple only returns Search Term Popularity rows that meet its reporting thresholds. Missing eligible rows are therefore treated as unavailable rather than authentication failures or stale valid scores.
Validation
xcodebuild test ...— 684 tests in 60 suites passedquick_checkreturnedokflight trackerchanged from stale popularity 61 to fresh popularity 60, persisted with sourceappleAdsPopularityand no status errorSecurity and privacy