feat(pipeline+bindings): Support encoding pairs of sequences - #2237
Draft
SBrandeis wants to merge 1 commit into
Draft
feat(pipeline+bindings): Support encoding pairs of sequences#2237SBrandeis wants to merge 1 commit into
SBrandeis wants to merge 1 commit into
Conversation
ArthurZucker
left a comment
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
As much as I hate it, it is indeed used quite a lot
Comment on lines
+642
to
+644
| TemplatePart::Specials { ids, type_id } if add_special_tokens => output.extend_from_slice(ids), | ||
| TemplatePart::Sequence { sequence_idx: SequenceIdx::First, type_id } => self.encode_single::<STAGE>(first, add_special_tokens, pre_tokens, scratch, output)?, | ||
| TemplatePart::Sequence { sequence_idx: SequenceIdx::Second, type_id } => self.encode_single::<STAGE>(second, add_special_tokens, pre_tokens, scratch, output)?, |
Collaborator
There was a problem hiding this comment.
actually given the way we do close to 0 allocations now, this might be fine!
Packing the two sequences in a single str might not do it any good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.