feat: re-introduce pretokens scratch buffers \(thread_local\) - #2284
Open
McPatate wants to merge 1 commit into
Open
feat: re-introduce pretokens scratch buffers \(thread_local\)#2284McPatate wants to merge 1 commit into
thread_local\)#2284McPatate wants to merge 1 commit into
Conversation
Signed-off-by: Luc Georges <luc.sydney.georges@gmail.com>
McPatate
requested review from
ArthurZucker and
SBrandeis
and
a lite review from Copilot
August 4, 2026 17:13
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Pull request overview
Re-introduces a persistent (per-thread) scratch buffer for pre-token spans in the PipelineTokenizer encode path to reduce repeated allocations during pre-tokenization.
Changes:
- Add a module-level
thread_local!PRE_TOKENS_SCRATCH: RefCell<Vec<Span>>. - Update
encode_genericto reusePRE_TOKENS_SCRATCHinstead of allocating a freshpre_tokensVecper call. - Keep
outputallocation local while removing the localpre_tokensallocation.
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
847
to
849
| input: &str, | ||
| add_special_tokens: bool, | ||
| ) -> Result<Vec<PipelineToken>> { |
Comment on lines
+883
to
+886
| let mut pre_tokens = cell.borrow_mut(); | ||
| pre_tokens.clear(); | ||
| self.pre_tokenizer | ||
| .pre_tokenize(normalized_chunk, &mut pre_tokens)?; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.