Use content hash for mlinter review deduplication - #47830
Merged
Conversation
Instead of skipping whenever any review with the marker exists, embed a short SHA-256 hash of the findings in the marker and compare it on each run. This allows re-posting when findings change across commits while still skipping identical findings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Instead of paginating all PR reviews to find the marker, embed a state block in the PR description containing the findings hash, commit SHA, and a link to the review. On each run, read the PR description (1 API call), compare the stored hash against current findings, and skip if unchanged. Update the state block after posting a new review. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
CI recapDashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves deduplication in
post_mlinter_review.py: instead of paginating all PR reviews to find a marker (O(n) API calls), store mlinter state in the PR description itself (O(1)).Before: scan all reviews for
<!-- mlinter-review -->, skip if found — always skips after the first post regardless of whether findings changed.After: embed a state block in the PR description with the findings hash, commit SHA, and a link to the review. On each run:
The findings hash is a short SHA-256 over the sorted
(path, line, rule, message)tuples, excluding parse-error sentinels (rule=None).The state block in the PR description looks like:
Why PR description (not a separate comment)?
Storing state in a separate PR comment would require scanning all comments to find it — same O(n) problem. The PR description is the only place that can be read and written in O(1) without an external store.
Related
🤖 Generated with Claude Code