Skip missing phpcs vendor paths instead of hardcoding them - #164
Open
jerico wants to merge 3 commits into
Open
Conversation
Hardcoded vendor paths make phpcs fail when a path is absent in the v2.x standards bundle. Include each path only if it exists.
jerico
marked this pull request as ready for review
August 18, 2026 09:42
WPCS 3.x / VIP 3.x pull these in as dependencies for the Universal.*/NormalizedArrays.* sniffs. Confirmed missing via a real v2.5.0 coding-standards build — phpcs failed to resolve those sniffs without them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardcoded vendor paths make phpcs fail when a path is absent in the v2.x standards bundle. Include each path only if it exists.
This is a prerequisite for PHP 8.2 / coding-standards v2.x support. Two things still needed (outside this repo):
Part of https://github.com/humanmade/product-dev/issues/1665