Fix bugs of ACF and featured media - #91
Open
ixkaito wants to merge 7 commits into
Open
Conversation
… previous image or file field data due to filter order.
- Update for core and - Fix bugs of ACF Pro (or repeater field) - Fix bugs of featured media
|
Thank you! |
Fix: Prevent PHP Warning when get_current_screen() returns null
Fix ACF bug with image and file fields in repeatable fields returning the previous image or file field data due to filter order.
Comment on lines
+408
to
+409
| remove_filter( 'the_content', 'wp_filter_content_tags' ); | ||
| add_filter( 'the_content', __NAMESPACE__ . '\filter_content_tags' ); |
There was a problem hiding this comment.
should we create some backwards compatibility here? wp_filter_content_tags is only available as of WordPress v5.5, and this repo says it's compatible to WordPress 4.9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following.
wp_make_content_images_responsive()is deprecated and thewp_make_content_images_responsivehook was removed.wp_filter_content_tags()and thewp_filter_content_tagshook instead.acf/format_value/type={$type}.rest_pre_insert_{$post_type}hook to get the featured image ID