feat: Add custom onClick field to external dashboards API#2156
Draft
pulpdrew wants to merge 1 commit intodrew/dashboard-filter-linkingfrom
Draft
feat: Add custom onClick field to external dashboards API#2156pulpdrew wants to merge 1 commit intodrew/dashboard-filter-linkingfrom
pulpdrew wants to merge 1 commit intodrew/dashboard-filter-linkingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 61ad06c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pulpdrew
changed the title
Contributor
Knip - Unused Code Analysis🔴 1 issue found Unused exports (1)
Knip finds unused files, dependencies, and exports in your codebase. |
pulpdrew
force-pushed
the
drew/dashboard-linking-external-api
branch
from
b8167a4 to
4092322
Compare
Contributor
E2E Test Results✅ All tests passed • 156 passed • 3 skipped • 1162s
Tests ran across 4 shards in parallel. |
pulpdrew
force-pushed
the
drew/dashboard-filter-linking
branch
2 times, most recently
from
de0c501 to
226d4ff
Compare
pulpdrew
force-pushed
the
drew/dashboard-linking-external-api
branch
from
4092322 to
452d359
Compare
pulpdrew
force-pushed
the
drew/dashboard-linking-external-api
branch
from
452d359 to
61ad06c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the fifth in a series of PRs adding customizable on-click / linking behaviors to dashboard tables. This PR extends the custom dashboard table onClick behavior from #2140.
This feature is behind the
NEXT_PUBLIC_IS_DASHBOARD_LINKING_ENABLED, which has been enabled in the preview environment and for local development.Scope
In this PR: The external dashboards API now supports CRUD for dashboards with custom onClick behaviors.
Not included yet
Future PRs will add:
Screenshots or video
How to test locally or on Vercel
This must be tested locally because the external API doesn't run in the preview environment
To test:
References