feat: Add per-series number formats by pulpdrew · Pull Request #2174 · hyperdxio/hyperdx

pulpdrew · 2026-04-29T01:05:46Z

Summary

This PR adds per-series number formats (for chart-builder-based charts). This allows the user to specify a different number format for different table columns or series.

For series without formats defined, the existing config's format is applied (if applicable). If there's no chart-wide format, then we attempt to infer a duration type format for any series aggregating the Trace Duration field. (re-using the previous logic for inferring duration number formats).

This PR includes updates the external API to support the new per-series numberFormat field.

This PR also updates various charts on the services dashboard which previously displayed ms units for non-duration series. These charts now only show ms formatting for duration aggregations.

Screenshots or video

Screen.Recording.2026-04-29.at.10.07.45.AM.mov

Services Dashboard:

How to test locally or on Vercel

Most of this can be tested in the preview environment in a dashboard or in the chart explorer. The external API updates can be tested locally by running CRUD requests against a dashboard, specifying per-series number formats.

References

Linear Issue: Closes HDX-3609
Related PRs:

changeset-bot · 2026-04-29T01:05:50Z

🦋 Changeset detected

Latest commit: b4af62f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@hyperdx/common-utils	Minor
@hyperdx/api	Minor
@hyperdx/app	Minor
@hyperdx/otel-collector	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-04-29T01:05:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	Apr 30, 2026 5:59am

github-actions · 2026-04-29T01:14:06Z

E2E Test Results

✅ All tests passed • 161 passed • 3 skipped • 1173s

Status	Count
✅ Passed	161
❌ Failed	0
⚠️ Flaky	3
⏭️ Skipped	3

Tests ran across 4 shards in parallel.

View full report →

github-actions · 2026-04-29T01:32:29Z

🔴 Tier 4 — Critical

Touches auth, data models, config, tasks, OTel pipeline, ClickHouse, or CI/CD.

Why this tier:

Critical-path files (2):
- packages/api/src/routers/external-api/v2/dashboards.ts
- packages/api/src/routers/external-api/v2/utils/dashboards.ts
Cross-layer change: touches frontend (packages/app) + backend (packages/api) + shared utils (packages/common-utils)

Review process: Deep review from a domain expert. Synchronous walkthrough may be required.
SLA: Schedule synchronous review within 2 business days.

Stats

Production files changed: 20
Production lines changed: 669 (+ 805 in test files, excluded from tier calculation)
Branch: drew/per-series-number-format
Author: pulpdrew

To override this classification, remove the review/tier-4 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

github-actions · 2026-04-29T01:34:59Z

PR Review

⚠️ Index-based series→column mapping is fragile (source.ts:useChartNumberFormats, lines ~1997–2009): The loop assumes config.select[i] maps to meta[i]. If groupBy columns appear in meta before value columns (or query engine reorders outputs), formats will be silently misassigned to wrong columns. The comment documents this assumption, but there's no guard. Consider verifying this assumption holds for all chart types that call this hook with meta (DBTableChart, DBListBarChart, DBTimeChart).
⚠️ tooltipNumberFormatsByKey is now required on MemoChart (HDXMultiSeriesTimeChart.tsx:263): It changed from optional numberFormat?: NumberFormat to required tooltipNumberFormatsByKey: Map<string, NumberFormat>. The only current call site (DBTimeChart) passes it correctly, but this is a breaking internal API change that any future direct MemoChart usage would silently fail on at runtime if TypeScript isn't checked strictly.
⚠️ UseFormSetValue type mismatch (NumberFormat.tsx:534, SeriesNumberFormatDrawer.tsx:1637): NumberFormatForm expects UseFormSetValue<ChartConfigDisplaySettings> but SeriesNumberFormatDrawer passes UseFormSetValue<{ numberFormat?: NumberFormat }> — a narrower form type. Works at runtime since only numberFormat is ever set, but this is a type unsafety that TypeScript may not catch depending on how contravariance is applied.
✅ Bundled bug fix in ServiceDashboardEndpointPerformanceChart.tsx (line ~1716): "Calls per Request" was dividing by Average Duration instead of Number of Requests — this fix is correct and worth calling out explicitly in the PR description.
✅ No security issues found. The external API schema change correctly uses the existing NumberFormatSchema with Zod validation, and the pick() calls in the API conversion utilities explicitly allowlist numberFormat, preventing unintended field passthrough.

pulpdrew · 2026-04-29T01:51:38Z

+      numberFormat ??
+      (Array.isArray(select)
+        ? getFirstSeriesNumberFormat(select, tableSource)
+        : undefined),
+    [numberFormat, select, tableSource],


Only auto-detect the number format if there is no existing chart-wide table format set

fleon · 2026-04-30T02:09:30Z

+        await dashboardPage.createNewDashboard();
+      });
+
+      test('per-series format overrides chart-wide format and falls back when reset to inherit', async () => {


praise: very well written feature specs 👍

question (non-blocking): do we really need a 60s timeout? can we shorten it?

Reduced to 15 seconds. That's still probably pretty conservative, but the page can load pretty slowly in CI sometimes.

fleon · 2026-04-30T02:13:12Z

+
+  // --- chartFormat resolution ---
+
+  it('uses config.numberFormat as chartFormat when set', () => {


nit (non-blocking): we can probably use parameterized tests to dry some of these tests up

Good idea, updated.

pulpdrew marked this pull request as ready for review April 29, 2026 01:31

github-actions Bot added the review/tier-4 Critical — deep review + domain expert sign-off label Apr 29, 2026

pulpdrew commented Apr 29, 2026

View reviewed changes

pulpdrew force-pushed the drew/per-series-number-format branch from d5d98a7 to fd4f3c0 Compare April 29, 2026 05:01

vercel Bot deployed to Preview April 29, 2026 05:03 View deployment

feat: Add per-series number formats

4113c42

pulpdrew force-pushed the drew/per-series-number-format branch from fd4f3c0 to 4113c42 Compare April 29, 2026 05:11

vercel Bot deployed to Preview April 29, 2026 05:13 View deployment

pulpdrew requested review from a team and fleon and removed request for a team April 29, 2026 05:27

fleon previously approved these changes Apr 30, 2026

View reviewed changes

pulpdrew dismissed fleon’s stale review via d38ba0b April 30, 2026 04:35

vercel Bot deployed to Preview April 30, 2026 04:38 View deployment

review: Address review feedback

a81bfd2

pulpdrew force-pushed the drew/per-series-number-format branch from d38ba0b to a81bfd2 Compare April 30, 2026 04:39

vercel Bot deployed to Preview April 30, 2026 04:42 View deployment

fleon previously approved these changes Apr 30, 2026

View reviewed changes

pulpdrew added the automerge label Apr 30, 2026

Merge branch 'main' into drew/per-series-number-format

1af1ac1

vercel Bot deployed to Preview April 30, 2026 05:37 View deployment

pulpdrew removed the automerge label Apr 30, 2026

fix: Fix per series formatting of line chart tooltips with group by

b4af62f

pulpdrew dismissed fleon’s stale review via b4af62f April 30, 2026 05:56

vercel Bot deployed to Preview April 30, 2026 05:59 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add per-series number formats#2174

feat: Add per-series number formats#2174
pulpdrew wants to merge 4 commits intomainfrom
drew/per-series-number-format

pulpdrew commented Apr 29, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

pulpdrew Apr 29, 2026

Uh oh!

Uh oh!

fleon Apr 30, 2026

Uh oh!

pulpdrew Apr 30, 2026

Uh oh!

fleon Apr 30, 2026

Uh oh!

pulpdrew Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		// --- chartFormat resolution ---

		it('uses config.numberFormat as chartFormat when set', () => {

Conversation

pulpdrew commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots or video

How to test locally or on Vercel

References

Uh oh!

changeset-bot Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Test Results

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔴 Tier 4 — Critical

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Uh oh!

pulpdrew Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fleon Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

pulpdrew Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

fleon Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

pulpdrew Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pulpdrew commented Apr 29, 2026 •

edited

Loading

changeset-bot Bot commented Apr 29, 2026 •

edited

Loading

vercel Bot commented Apr 29, 2026 •

edited

Loading

github-actions Bot commented Apr 29, 2026 •

edited

Loading

github-actions Bot commented Apr 29, 2026 •

edited

Loading

github-actions Bot commented Apr 29, 2026 •

edited

Loading