fix: use character-level word breaking in Lucene search input#2181
fix: use character-level word breaking in Lucene search input#2181kodiakhq[bot] merged 4 commits intomainfrom
Conversation
Long Lucene filter queries were truncated in the default (unfocused) view with no way to expand or see the full expression. This change makes the Lucene input behave consistently with the SQL WHERE input: - Unfocused: single-line display with fade gradient indicating overflow - Focused: expands to show full query with text wrapping (up to 150px, then scrollable) Changes: - Remove maxRows cap when focused (was 4, now unlimited via CSS max-height) - Add max-height: 150px and overflow-y: auto on focused textarea - Keep single-line collapsed state with overflow: hidden when unfocused Fixes HDX-4134 Co-authored-by: Mike Shi <mike@hyperdx.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
E2E Test Results✅ All tests passed • 158 passed • 3 skipped • 1186s
Tests ran across 4 shards in parallel. |
This reverts commit e4ec20a.
Long Lucene filter queries with long attribute values (e.g. key:[really_long_attribute_name]) were wrapping at word boundaries, causing the key to appear on a separate line from its value: key: [really_long_attribute] With word-break: break-all, text now breaks at character boundaries, keeping the key and value together on the same line: key: [really_long_at tribute] This ensures text is packed as tightly as possible on each line, making long queries more readable regardless of whether they contain spaces. Fixes HDX-4134 Co-authored-by: Mike Shi <mike@hyperdx.io>
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
PR Review✅ No critical issues found. Single-line CSS change ( |
Summary
Long Lucene filter queries with long attribute values (e.g.
key:[really_long_attribute_name]) were wrapping at word boundaries, causing the key to appear on a separate line from its value. Withword-break: break-all, text now breaks at character boundaries, keeping the key and value together on the same line.This ensures text is packed as tightly as possible on each line, making long queries more readable regardless of whether they contain spaces.
Screenshots or video
Before:
service.name:wraps to its own line, then the long attribute starts on the next line — wastes space and separates the key from its value.After: Text breaks at character boundaries, keeping
service.name:[really_long_long...packed on the first line and continuing mid-character on the next line.How to test locally or on Vercel
service.name:[really_long_long_long_long_attribute_that_wraps_and_causes_issues]key:valueto the next lineReferences
To show artifacts inline, enable in settings.
Linear Issue: HDX-4134