fix: invalid enum on container schemas in OpenAPI generation#227
Merged
Conversation
The ffenum tag handler applied schema.Enum unconditionally. For container fields ([]FFEnum, map[string]FFEnum) the openapi3gen library invokes the schema customizer with the same field tag for both the container schema and its element schema, so the enum was stamped on the "array"/"object" container node as well as the string leaf. An enum on a type:array or type:object node is invalid OpenAPI and is rejected by strict SDK generators (kin-openapi's own Validate() does not catch it). Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
peterbroadhurst
approved these changes
Jun 30, 2026
peterbroadhurst
left a comment
peterbroadhurst
left a comment
Contributor
There was a problem hiding this comment.
Thanks @EnriqueL8 - this looks very clear to me
onelapahead
approved these changes
Jun 30, 2026
onelapahead
left a comment
onelapahead
left a comment
Contributor
There was a problem hiding this comment.
Can we add an openapi linter utility ?
Contributor
Author
|
We can add an openapi linter in a following PR, looked into different package vaccuum could be one https://github.com/daveshanley/vacuum |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ffenum tag handler applied schema.Enum unconditionally. For container fields ([]FFEnum, map[string]FFEnum) the openapi3gen library invokes the schema customizer with the same field tag for both the container schema and its element schema, so the enum was stamped on the "array"/"object" container node as well as the string leaf. An enum on a type:array or type:object node is invalid OpenAPI and is rejected by strict SDK generators (kin-openapi's own Validate() does not catch it).