Exclude TLS key password from chaincode server log#547
Merged
Conversation
The constructor for the NettyGrpcServer implementation included an info level log of all of the chaincode server properties, including the TLS key password. While both the key and accompanying password are necessary to allow the chaincode server to be impersonated, an attacker with access to the chaincode server filesystem where the key is stored would likely also have access to the logs containing the key password. The password is sensitive information that should not be logged regardless. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor for the NettyGrpcServer implementation included an info level log of all of the chaincode server properties, including the TLS key password. While both the key and accompanying password are necessary to allow the chaincode server to be impersonated, an attacker with access to the chaincode server filesystem where the key is stored would likely also have access to the logs containing the key password. The password is sensitive information that should not be logged regardless.