feat(virtq): add packed virtio ring primitives#1382
Open
andreiltd wants to merge 1 commit intohyperlight-dev:mainfrom
Open
feat(virtq): add packed virtio ring primitives#1382andreiltd wants to merge 1 commit intohyperlight-dev:mainfrom
andreiltd wants to merge 1 commit intohyperlight-dev:mainfrom
Conversation
andreiltd
requested review from
danbugs,
dblnz,
devigned,
jprendes,
ludfjig,
marosset,
simongdavies and
syntactically
as code owners
andreiltd
force-pushed
the
tandr/virtq-1-ring
branch
from
3db3820 to
bd2fd96
Compare
andreiltd
added
the
kind/enhancement
andreiltd
force-pushed
the
tandr/virtq-1-ring
branch
from
bd2fd96 to
b4c8142
Compare
Add low-level packed virtqueue ring implementation in hyperlight_common::virtq, based on the virtio packed ring format. Signed-off-by: Tomasz Andrzejak <andreiltd@gmail.com>
andreiltd
force-pushed
the
tandr/virtq-1-ring
branch
from
b4c8142 to
16de50c
Compare
dblnz
reviewed
Apr 16, 2026
Contributor
dblnz
left a comment
dblnz
left a comment
There was a problem hiding this comment.
Great stuff, @andreiltd !
I left a few comments, most are small remarks, others are things I might have missed.
This is part 1 of my review, I still have some things left to look at that I plan on doing tomorrow.
| /// | ||
| /// # Safety | ||
| /// | ||
| /// The caller must ensure `paddr` is valid and points to at least `dst.len()` bytes. |
Contributor
There was a problem hiding this comment.
Nit:
Suggested change
| /// The caller must ensure `paddr` is valid and points to at least `dst.len()` bytes. | |
| /// The caller must ensure `addr` is valid and points to at least `dst.len()` bytes. |
| /// | ||
| /// # Safety | ||
| /// | ||
| /// The caller must ensure `paddr` is valid and points to at least `src.len()` bytes. |
Contributor
There was a problem hiding this comment.
Nit:
Suggested change
| /// The caller must ensure `paddr` is valid and points to at least `src.len()` bytes. | |
| /// The caller must ensure `addr` is valid and points to at least `src.len()` bytes. |
| /// | ||
| /// # Invariant | ||
| /// | ||
| /// The caller must ensure that `base` is valid for writes of Descriptor |
Contributor
There was a problem hiding this comment.
I think base has been renamed
| /// | ||
| /// # Safety | ||
| /// | ||
| /// - `base` must be valid for reads and writes of `size` descriptors |
Contributor
There was a problem hiding this comment.
Suggested change
| /// - `base` must be valid for reads and writes of `size` descriptors | |
| /// - `base_addr` must be valid for reads and writes of `size` descriptors |
| /// # Safety | ||
| /// | ||
| /// - `base` must be valid for reads and writes of `size` descriptors | ||
| /// - `base` must be properly aligned for `Descriptor` |
Contributor
There was a problem hiding this comment.
Suggested change
| /// - `base` must be properly aligned for `Descriptor` | |
| /// - `base_addr` must be properly aligned for `Descriptor` |
| #[derive(Clone, Copy, Debug, Pod, Zeroable, PartialEq, Eq, Hash)] | ||
| pub struct EventSuppression { | ||
| // bits 0-14: offset, bit 15: wrap | ||
| pub off_wrap: u16, |
Contributor
There was a problem hiding this comment.
Are the fields necessary to be pub? Is the logic using it outside of hyperlight_common?
Contributor
There was a problem hiding this comment.
Do all these defined types need to be pub?
| /// and readable buffers must be added before writable buffers. | ||
| #[derive(Debug, Default)] | ||
| pub struct BufferChainBuilder<T> { | ||
| elems: SmallVec<[BufferElement; 16]>, |
Contributor
There was a problem hiding this comment.
Maybe documenting this 16 inline capacity as an optimization for the user to be aware
|
|
||
| /// Advance to next position, wrapping around and toggling wrap counter if needed | ||
| #[inline] | ||
| pub(crate) fn advance(&mut self) { |
Contributor
There was a problem hiding this comment.
Could this be called concurrently on the host?
|
|
||
| /// Advance by n positions using modular arithmetic. | ||
| #[inline] | ||
| pub(crate) fn advance_by(&mut self, n: u16) { |
Contributor
There was a problem hiding this comment.
Nit: Maybe have advance be advance_by(1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add low-level packed virtqueue ring implementation in
hyperlight_common::virtq, based on the virtio packed ring format.This is split from: #1368 and does not include any actual plumbing for guest/host communication.
Useful materials: