Re-export guest types and error utilities from hyperlight_guest_bin#1383
Open
jprendes wants to merge 1 commit intohyperlight-dev:mainfrom
Open
Re-export guest types and error utilities from hyperlight_guest_bin#1383jprendes wants to merge 1 commit intohyperlight-dev:mainfrom
hyperlight_guest_bin#1383jprendes wants to merge 1 commit intohyperlight-dev:mainfrom
Conversation
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
requested review from
danbugs,
dblnz,
devigned,
ludfjig,
marosset,
simongdavies and
syntactically
as code owners
jprendes
added
the
kind/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR re-exports common types and error utilities from
hyperlight_guest_bin, allowing users to build guest binaries with a single dependency onhyperlight_guest_bininstead of requiring an explicit dependency on bothhyperlight_guestandhyperlight_guest_bin.Changes
ErrorCodefromhyperlight_guest::errortypesmodule tohyperlight_guestthat re-exportsFunctionCall,ParameterType,ParameterValue,ReturnType, andReturnValueerrormodule tohyperlight_guest_binthat re-exports error types and thebail/ensuremacrosMotivation
Simplifies the dependency graph for guest binary authors by allowing them to depend only on
hyperlight_guest_bin.