Skip to content

Add path and rock landscape primitives#80

Merged
madawei2699 merged 1 commit into
mainfrom
codex/path-rock-primitives
Jun 15, 2026
Merged

Add path and rock landscape primitives#80
madawei2699 merged 1 commit into
mainfrom
codex/path-rock-primitives

Conversation

@madawei2699

Copy link
Copy Markdown
Contributor

Summary

  • add PathRun for continuous, gravel, and stepping-stone paths with local waypoints
  • add RockCluster for deterministic boulder and dry-garden rock groups
  • add a path/rock garden sample plus docs and LLM authoring guidance

Closes #73

Tests

  • pnpm --filter @i365dev/craftdag-core test
  • pnpm --filter @i365dev/craftdag-core typecheck
  • pnpm lint

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@madawei2699 madawei2699 merged commit 3f67612 into main Jun 15, 2026
1 check passed
@madawei2699 madawei2699 deleted the codex/path-rock-primitives branch June 15, 2026 21:49

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new component types, PathRun and RockCluster, to the ComponentPlan specification and core package. PathRun allows defining deterministic local paths (such as stepping stones or gravel paths) using waypoints, while RockCluster enables the generation of deterministic groups of rough boulders. The changes include updating the Zod schemas, validation logic, expansion algorithms, and block estimation, alongside adding comprehensive documentation, tests, and a new example garden composition. There are no review comments to address, and the implementation looks solid.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate landscape primitives for trees, paths, ponds, and rock gardens

1 participant