Skip to content

Use StairRun in reference samples#86

Merged
madawei2699 merged 1 commit into
mainfrom
codex/stair-run-reference-samples
Jun 16, 2026
Merged

Use StairRun in reference samples#86
madawei2699 merged 1 commit into
mainfrom
codex/stair-run-reference-samples

Conversation

@madawei2699

Copy link
Copy Markdown
Contributor

Summary

  • add StairRun access points to the large castle reference sample
  • add a machinery-to-cabin-deck StairRun to the large ship interior sample
  • keep survival coverage through the existing stair-run multilevel sample

Validation

  • pnpm --filter @i365dev/craftdag-core test
  • pnpm --filter @i365dev/craftdag-core typecheck
  • pnpm lint

@madawei2699 madawei2699 merged commit de565e1 into main Jun 16, 2026
1 check passed
@madawei2699 madawei2699 deleted the codex/stair-run-reference-samples branch June 16, 2026 09:14

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several StairRun components to the example component plans, specifically introducing stairs for the large castle and the large ship interior. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ab676f302

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +395 to +396
"anchor": { "x": 19, "y": 2, "z": 17 },
"size": { "width": 3, "height": 8, "length": 8 }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Move the wall stair onto the wall walk

In this reference sample, the new StairRun uses axis: "z", direction: "negative", and this anchor/size, so its highest step lands at z=17/y=9 while the north wall walk instances are at z=7–10/y=10; there is no component bridging z=11–16. As a result the component named courtyard_to_wall_walk_access stops several blocks short of the wall walk and does not provide the advertised access in the generated castle.

Useful? React with 👍 / 👎.

Comment on lines +183 to +187
"anchor": {
"x": 34,
"y": 1,
"z": 19
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Cut a real opening for the service stair

This anchor puts the new stair entirely inside cargo_hold's footprint (the hold spans x=10–57, y=1–5, z=19–28 and still has the default ceiling), while the stair only depends on keel_floor. In the compiled ship sample the cargo-hold shell is therefore still emitted over the stair route, including the ceiling at y=5 and end walls, so the supposed cabin-deck access is partially buried/capped instead of forming a usable passage; move it out of the sealed hold or adjust the hold/opening and dependencies so the stair can breach the deck.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant