Use StairRun in reference samples#86
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds several StairRun components to the example component plans, specifically introducing stairs for the large castle and the large ship interior. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ab676f302
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "anchor": { "x": 19, "y": 2, "z": 17 }, | ||
| "size": { "width": 3, "height": 8, "length": 8 } |
There was a problem hiding this comment.
Move the wall stair onto the wall walk
In this reference sample, the new StairRun uses axis: "z", direction: "negative", and this anchor/size, so its highest step lands at z=17/y=9 while the north wall walk instances are at z=7–10/y=10; there is no component bridging z=11–16. As a result the component named courtyard_to_wall_walk_access stops several blocks short of the wall walk and does not provide the advertised access in the generated castle.
Useful? React with 👍 / 👎.
| "anchor": { | ||
| "x": 34, | ||
| "y": 1, | ||
| "z": 19 | ||
| }, |
There was a problem hiding this comment.
Cut a real opening for the service stair
This anchor puts the new stair entirely inside cargo_hold's footprint (the hold spans x=10–57, y=1–5, z=19–28 and still has the default ceiling), while the stair only depends on keel_floor. In the compiled ship sample the cargo-hold shell is therefore still emitted over the stair route, including the ceiling at y=5 and end walls, so the supposed cabin-deck access is partially buried/capped instead of forming a usable passage; move it out of the sealed hold or adjust the hold/opening and dependencies so the stair can breach the deck.
Useful? React with 👍 / 👎.
Summary
Validation