Skip to content

Add SteppedDome component#87

Merged
madawei2699 merged 1 commit into
mainfrom
codex/stepped-dome
Jun 16, 2026
Merged

Add SteppedDome component#87
madawei2699 merged 1 commit into
mainfrom
codex/stepped-dome

Conversation

@madawei2699

Copy link
Copy Markdown
Contributor

Summary

  • add SteppedDome as a bounded Minecraft-style dome primitive for landmark roofs and caps
  • support filled and hollow stepped tiers, validation, budgeting, repeat expansion, material fallbacks, and source metadata
  • add Taj dome reference sample plus agent-facing docs

Closes #83

Validation

  • pnpm --filter @i365dev/craftdag-core test
  • pnpm --filter @i365dev/craftdag-core typecheck
  • pnpm lint

@madawei2699 madawei2699 merged commit ceeab09 into main Jun 16, 2026
1 check passed
@madawei2699 madawei2699 deleted the codex/stepped-dome branch June 16, 2026 09:25

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new SteppedDome component type, which represents a bounded Minecraft-style dome approximation made of stacked shrinking tiers. The changes include comprehensive documentation updates, a Zod schema definition, expansion and validation logic within the core engine, TypeScript type definitions, a new example component plan for a Taj-style dome study, and thorough unit tests verifying its behavior. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evaluate stepped dome and ring primitives for radial landmark forms

1 participant