Add landmark stress samples and coverage matrix#92
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2685885da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "options": { | ||
| "levels": 7, | ||
| "setbackPerLevel": 1, | ||
| "levelHeight": 7 |
There was a problem hiding this comment.
For this sample, pagoda_tower_mass declares a 54-block-tall VerticalSetbackVolume, but levels * levelHeight is only 49. The expander emits seven 7-block segments, so the body only reaches y=54 from anchor y=6 even though the component bounds extend to y=60; top_roof is then anchored at y=60 with this mass as its input, leaving a five-block air gap. That makes the new regression fixture visibly floating and turns the documented disconnected diagnostics into a sample-authoring error rather than a support-analysis limit; drop levelHeight or set it to 8 to fill the intended height.
Useful? React with 👍 / 👎.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two new monumental landmark studies—the Xi'an Bell Tower and the Giant Wild Goose Pagoda—along with corresponding test registration and documentation updates in the build coverage matrix. The review feedback highlights a critical 5-block vertical gap in the Giant Wild Goose Pagoda plan, where the tower mass height of 54 does not match its 7-level, 7-block-height specification (which should be 49). This discrepancy causes the roof and finial to float, resulting in thousands of disconnected block warnings. Adjusting the tower height to 49 and shifting the roof and finial anchors down resolves this gap and corrects the diagnostic interpretations documented in the coverage matrix.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| }, | ||
| "size": { | ||
| "width": 28, | ||
| "height": 54, |
There was a problem hiding this comment.
There is an arithmetic mismatch in the height of the pagoda_tower_mass component. The pagoda is designed with 7 stories, each having a height of 7 blocks (levels: 7, levelHeight: 7), which sums up to a total height of 49 blocks. However, size.height is set to 54. This 5-block discrepancy leaves a physical gap between the top of the tower (ending at y: 55) and the top_roof (starting at y: 60), causing the roof and finial to float and generating 27,972 disconnected block warnings. Changing the height to 49 resolves this gap.
| "height": 54, | |
| "height": 49, |
| "placement": { | ||
| "anchor": { | ||
| "x": 26, | ||
| "y": 60, |
There was a problem hiding this comment.
To align with the corrected 49-block height of the pagoda_tower_mass (ending at y: 55), the top_roof anchor should be shifted down from y: 60 to y: 55. This ensures the roof sits perfectly on top of the 7th story of the pagoda.
| "y": 60, | |
| "y": 55, |
| "placement": { | ||
| "anchor": { | ||
| "x": 35, | ||
| "y": 68, |
There was a problem hiding this comment.
To align with the corrected position of the top_roof (which has a height of 8 and starts at y: 55, ending at y: 63), the pagoda_finial anchor should be shifted down from y: 68 to y: 63.
| "y": 68, | |
| "y": 63, |
| | `taj-dome-study` | pass | pass | 30 | 1724 | 0 | Dome tier support diagnostics need refinement or explicit intent | | ||
| | `temple-palace-dome-study` | pass | pass | 58 | 828 | 0 | Assembly authoring works; dome diagnostics remain noisy | | ||
| | `xi-an-bell-tower-study` | pass | pass | 20 | 108 | 728 | Good visual landmark probe; broad eaves create intentional span/cantilever review points | | ||
| | `giant-wild-goose-pagoda-study` | pass | pass | 18 | 27972 | 0 | Strong probe for `VerticalSetbackVolume` support analysis limits | |
There was a problem hiding this comment.
The 27,972 disconnected blocks reported here are not due to a diagnostic gap or support analysis limit in the engine. Instead, they are caused by a literal 5-block vertical gap in the giant-wild-goose-pagoda-study coordinates (the tower mass ends at y: 55, but the top roof starts at y: 60). Once the coordinates are corrected, this disconnected block count should drop to 0.
|
Updated after visual feedback and Gemini review:
Validation rerun:
|
1 participant
Summary
Notes
Validation