Skip to content

Add large build ComponentPlan samples#35

Merged
madawei2699 merged 2 commits into
mainfrom
codex/large-build-samples
Jun 14, 2026
Merged

Add large build ComponentPlan samples#35
madawei2699 merged 2 commits into
mainfrom
codex/large-build-samples

Conversation

@madawei2699

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade CraftDAG packages to 0.1.4 so MinePilot can consume ComponentPlan assemblies and Instance expansion.
  • Add Large Modular Castle and Long Fortified Bridge samples to the examples gallery and playground.
  • Add a Large Build category and update copy from small-only language to bounded builds.

Validation

  • corepack pnpm lint
  • corepack pnpm build
  • Browser smoke test: /examples shows Large Build, Large Modular Castle, and Long Fortified Bridge; /playground?sample=large-modular-castle renders a preview canvas.

Notes

The sample factories generate ComponentPlan objects with assemblies at runtime, so the playground still shows full JSON while the source stays maintainable.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 14, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
myminepilot-web eeb3263 Jun 14 2026, 06:38 AM

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dependencies for @i365dev/craftdag-core and @i365dev/craftdag-exporter-schem to version 0.1.4, introduces a new large_build category, and updates metadata descriptions to refer to "bounded" instead of "small" build plans. It also adds two new large-scale modular build samples: a "Large Modular Castle" and a "Long Fortified Bridge". The review feedback highlights alignment issues in both new plans: the castle's gatehouse overhangs its foundation by 1 block on the Z-axis, and the bridge's towers overhang the riverbed foundation. Suggestions are provided to adjust the anchors and dimensions to ensure proper alignment.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/utils/componentPlanSamples.ts Outdated
Comment thread src/utils/componentPlanSamples.ts Outdated
@madawei2699 madawei2699 merged commit 0e2519c into main Jun 14, 2026
1 of 2 checks passed
@madawei2699 madawei2699 deleted the codex/large-build-samples branch June 14, 2026 06:40

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea7071c160

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

name: "Large Modular Castle",
grid: { unitBlocks: 1 },
policy: { sizeTier: "large" },
bounds: { width: 80, height: 36, length: 80 },

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Scale preview zoom for large samples

With this 80×80 footprint, the playground preview can’t zoom out far enough in square or moderately wide panes: src/components/VoxelPreview.tsx still hard-codes controls.maxDistance = 100 while positioning the camera from maxDimension, so these newly advertised large samples can be clamped too close to frame the whole build in the existing three-pane layout. Please scale the OrbitControls distance limit from plan.size when adding large previewable builds.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant