feat: rename bulk environment variables - #20
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR renames bulk environment variables to use a consistent IEXEC_ prefix and consolidates the dataset variable handling into indexed variants. The changes standardize the naming convention and simplify the code by unifying how single and bulk datasets are accessed.
- Renamed
BULK_SIZEtoIEXEC_BULK_SLICE_SIZEand consolidatedBULK_DATASET_*variables into indexedIEXEC_DATASET_*variants - Unified dataset handling logic to use a single loop that handles both single (index 0) and bulk datasets (index 1+)
- Updated all references, tests, and documentation to reflect the new naming convention
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pre-compute/src/compute/utils/env_utils.rs | Updated enum variants and environment variable name mapping to use IEXEC_ prefix and indexed dataset variables |
| pre-compute/src/compute/pre_compute_args.rs | Consolidated dataset loading logic, renamed field from bulk_size to iexec_bulk_slice_size, updated documentation and tests |
| pre-compute/src/compute/pre_compute_app.rs | Updated test to use new field name iexec_bulk_slice_size |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jbern0rd
reviewed
Oct 9, 2025
jbern0rd
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.