Skip to content

feat: update ReplicateStatusCause serialization and worker_api to support new WorkflowError format - #21

Merged
nabil-Tounarti merged 12 commits into
mainfrom
feature/add-workflow-error
Oct 21, 2025
Merged

feat: update ReplicateStatusCause serialization and worker_api to support new WorkflowError format#21
nabil-Tounarti merged 12 commits into
mainfrom
feature/add-workflow-error

Conversation

@nabil-Tounarti

Copy link
Copy Markdown
Contributor

No description provided.

@nabil-Tounarti nabil-Tounarti self-assigned this Oct 14, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ReplicateStatusCause error handling system to include dataset indices and modifies the worker API to support a new WorkflowError format that accepts multiple causes.

  • Adds index parameters to dataset-related error variants to provide better error context
  • Replaces custom Serialize derivation with manual implementation for structured error serialization
  • Updates worker API to send arrays of errors instead of single error objects

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pre-compute/src/compute/errors.rs Adds index parameters to error variants and implements custom serialization with cause/message structure
pre-compute/src/compute/dataset.rs Updates dataset methods to accept index parameters and pass them to error constructors
pre-compute/src/compute/pre_compute_args.rs Updates error construction calls to include dataset indices
pre-compute/src/compute/pre_compute_app.rs Adds enumeration to dataset iteration to provide indices for error reporting
pre-compute/src/compute/utils/env_utils.rs Updates test to use new error variant with index parameter
pre-compute/src/compute/app_runner.rs Modifies API calls to send arrays of errors instead of single error objects
pre-compute/src/api/worker_api.rs Removes ExitMessage struct and updates API to handle arrays of ReplicateStatusCause

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread pre-compute/src/compute/errors.rs Outdated
Comment thread pre-compute/src/compute/app_runner.rs Outdated
Comment thread pre-compute/src/api/worker_api.rs Outdated
Comment thread pre-compute/src/compute/pre_compute_args.rs Outdated
@nabil-Tounarti
nabil-Tounarti merged commit 7491cf4 into main Oct 21, 2025
7 checks passed
@nabil-Tounarti
nabil-Tounarti deleted the feature/add-workflow-error branch October 21, 2025 14:00
Natchica pushed a commit that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants