feat: update ReplicateStatusCause serialization and worker_api to support new WorkflowError format - #21
Merged
Merged
Conversation
…port new WorkflowError format
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ReplicateStatusCause error handling system to include dataset indices and modifies the worker API to support a new WorkflowError format that accepts multiple causes.
- Adds index parameters to dataset-related error variants to provide better error context
- Replaces custom Serialize derivation with manual implementation for structured error serialization
- Updates worker API to send arrays of errors instead of single error objects
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pre-compute/src/compute/errors.rs | Adds index parameters to error variants and implements custom serialization with cause/message structure |
| pre-compute/src/compute/dataset.rs | Updates dataset methods to accept index parameters and pass them to error constructors |
| pre-compute/src/compute/pre_compute_args.rs | Updates error construction calls to include dataset indices |
| pre-compute/src/compute/pre_compute_app.rs | Adds enumeration to dataset iteration to provide indices for error reporting |
| pre-compute/src/compute/utils/env_utils.rs | Updates test to use new error variant with index parameter |
| pre-compute/src/compute/app_runner.rs | Modifies API calls to send arrays of errors instead of single error objects |
| pre-compute/src/api/worker_api.rs | Removes ExitMessage struct and updates API to handle arrays of ReplicateStatusCause |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Natchica
reviewed
Oct 15, 2025
jbern0rd
reviewed
Oct 21, 2025
jbern0rd
approved these changes
Oct 21, 2025
Natchica
approved these changes
Oct 21, 2025
Natchica
pushed a commit
that referenced
this pull request
Oct 21, 2025
…port new WorkflowError format (#21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.