Fix ORDS docs on the withheld problem column - #59
Merged
Conversation
ORDS_INCLUDE_PROBLEM withholds the value, not the column. The docs said the export drops to thirteen columns with the flag off, which would read to a consumer as non-conformance with a standard that defines fourteen. The mapper emits a fixed column list and the CSV header is a constant, so the shape never varies. A withheld problem comes back null in JSON and as an empty cell in CSV, the same as any other column with no value.
batbattur
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs clarification, no code change.
ORDS_INCLUDE_PROBLEMempties theproblemcolumn, it doesn't remove it.The docs from #58 said to expect thirteen columns with the flag off, but it's always fourteen:
OrdsRecordMapper::COLUMNSis a fixed list and the CSV header is written from it. A withheldproblemcomes backnullin JSON and as an empty cell in CSV, same as any other column with no value.qa_req 0