Adding truth info for FCC-ee ILD model, add vertex resolutions as inp… by armin-ilg · Pull Request #188 · iLCSoft/ILDConfig

armin-ilg · 2026-07-20T13:01:15Z

…ut arguments, update vertex detector naming scheme to be compliant also with FCC-SEED VXD (backwards compatible with CLD VXD), updating CT_MAX_DIST value to use the same as CLD with smaller beam pipe

BEGINRELEASENOTES

Add truth info to tracks in ILD@FCC-ee
Enable usage of FCC-SEED VXD with updated VXD system strings (backwards compatible with CLD VXD), see Adding FCC-SEED as option to all detectors and refactor IDEA/ALLEGRO vertex detector key4hep/k4geo#612
Updating CT_MAX_DIST to correct value (like in CLD)
ENDRELEASENOTES

…ut arguments, update vertex detector naming scheme to be compliant also with FCC-SEED VXD (backwards compatible with CLD VXD), updating CT_MAX_DIST value to use the same as CLD with smaller beam pipe

armin-ilg · 2026-07-20T13:01:41Z

@Victor-Schwan : As discussed, here's the PR with the changes to ILDConfig

Victor-Schwan · 2026-07-28T11:12:38Z

    action="store_true",
 )

+parser.add_argument(


The help messages of the DigitiserResolution options may also state that it is only applied to FCC models

Victor-Schwan · 2026-07-28T12:35:03Z

+                "VXDCollection",
+                "SITCollection",
+                "FTD_PIXELCollection",
+                "FTD_STRIPCollection",


These collections should not exists for reconstructed ILD@FCC-ee events. They are only present in ILD@ILC models. The corresponding collections are:

VertexBarrelCollection VertexEndcapCollection InnerTrackerBarrelCollection InnerTrackerEndcapCollection

Victor-Schwan · 2026-07-28T12:36:42Z

+                "VXDTrackerHitRelations",
+                "SITTrackerHitRelations",
+                "FTDPixelTrackerHitRelations",
+                "FTDSpacePointRelations",


See above (https://github.com/iLCSoft/ILDConfig/pull/188/changes#r3665519712)

Victor-Schwan · 2026-07-28T13:21:31Z

I have just realized that I have already a MCRecoTruthLinker with the correct collection names in my fork (see https://github.com/Victor-Schwan/ILDConfig/tree/fcc-tracking). Further, I assume we wanna place the MCRecoTruthLinker in a HighLevelReco_FCCee similar to the ILC reconstruction (see

ILDConfig/StandardConfig/production/HighLevelReco/HighLevelReco.py

Lines 206 to 262 in 279b180

    
           MyRecoMCTruthLinker = MarlinProcessorWrapper("MyRecoMCTruthLinker") 
        
           MyRecoMCTruthLinker.ProcessorType = "RecoMCTruthLinker" 
        
           MyRecoMCTruthLinker.Parameters = { 
        
               "CalohitMCTruthLinkName": ["CalohitMCTruthLink"], 
        
               "ClusterCollection": ["PandoraClusters"], 
        
               "ClusterMCTruthLinkName": ["ClusterMCTruthLink"], 
        
               "FullRecoRelation": ["true"], 
        
               "KeepDaughtersPDG": ["22", "111", "310", "13", "211", "321"], 
        
               "MCParticleCollection": ["MCParticle"], 
        
               "MCParticlesSkimmedName": ["MCParticlesSkimmed"], 
        
               "MCTruthClusterLinkName": ["MCTruthClusterLink"], 
        
               "MCTruthRecoLinkName": ["MCTruthRecoLink"], 
        
               "MCTruthTrackLinkName": ["MCTruthMarlinTrkTracksLink"], 
        
               "RecoMCTruthLinkName": ["RecoMCTruthLink"], 
        
               "RecoParticleCollection": ["PandoraPFOs"], 
        
               "SimCaloHitCollections": [ 
        
                   "BeamCalCollection", 
        
                   "LHCalCollection", 
        
                   "LumiCalCollection", 
        
                   CONSTANTS["ECalSimHitCollections"], 
        
                   CONSTANTS["HCalSimHitCollections"], 
        
                   "YokeBarrelCollection", 
        
                   "YokeEndcapsCollection", 
        
               ], 
        
               "SimCalorimeterHitRelationNames": [ 
        
                   "EcalBarrelRelationsSimRec", 
        
                   "EcalEndcapRingRelationsSimRec", 
        
                   "EcalEndcapsRelationsSimRec", 
        
                   "HcalBarrelRelationsSimRec", 
        
                   "HcalEndcapRingRelationsSimRec", 
        
                   "HcalEndcapsRelationsSimRec", 
        
                   "RelationLHcalHit", 
        
                   "RelationMuonHit", 
        
                   "RelationLcalHit", 
        
                   "RelationBCalHit", 
        
               ], 
        
               "SimTrackerHitCollections": [ 
        
                   "VXDCollection", 
        
                   "SITCollection", 
        
                   "FTD_PIXELCollection", 
        
                   "FTD_STRIPCollection", 
        
                   "TPCCollection", 
        
                   "SETCollection", 
        
               ], 
        
               "TrackCollection": ["MarlinTrkTracks"], 
        
               "TrackMCTruthLinkName": ["MarlinTrkTracksMCTruthLink"], 
        
               "TrackerHitsRelInputCollections": [ 
        
                   "VXDTrackerHitRelations", 
        
                   "SITTrackerHitRelations", 
        
                   "FTDPixelTrackerHitRelations", 
        
                   "FTDSpacePointRelations", 
        
                   "TPCTrackerHitRelations", 
        
                   "SETSpacePointRelations", 
        
               ], 
        
               "UseTrackerHitRelations": ["true"], 
        
               "UsingParticleGun": [str(using_particle_gun).lower()], 
        
           }

) and not in the ILDReconstruction.py. This is also already present in my fork. I guess it may make more sense to take the MCRecoTruthLinker from my fork?

Co-authored-by: Victor Schwan <162138084+Victor-Schwan@users.noreply.github.com>

armin-ilg · 2026-08-12T12:27:12Z

I have just realized that I have already a MCRecoTruthLinker with the correct collection names in my fork (see https://github.com/Victor-Schwan/ILDConfig/tree/fcc-tracking). Further, I assume we wanna place the MCRecoTruthLinker in a HighLevelReco_FCCee similar to the ILC reconstruction (see

ILDConfig/StandardConfig/production/HighLevelReco/HighLevelReco.py

Lines 206 to 262 in 279b180

MyRecoMCTruthLinker = MarlinProcessorWrapper("MyRecoMCTruthLinker")

MyRecoMCTruthLinker.ProcessorType = "RecoMCTruthLinker"

MyRecoMCTruthLinker.Parameters = {

"CalohitMCTruthLinkName": ["CalohitMCTruthLink"],

"ClusterCollection": ["PandoraClusters"],

"ClusterMCTruthLinkName": ["ClusterMCTruthLink"],

"FullRecoRelation": ["true"],

"KeepDaughtersPDG": ["22", "111", "310", "13", "211", "321"],

"MCParticleCollection": ["MCParticle"],

"MCParticlesSkimmedName": ["MCParticlesSkimmed"],

"MCTruthClusterLinkName": ["MCTruthClusterLink"],

"MCTruthRecoLinkName": ["MCTruthRecoLink"],

"MCTruthTrackLinkName": ["MCTruthMarlinTrkTracksLink"],

"RecoMCTruthLinkName": ["RecoMCTruthLink"],

"RecoParticleCollection": ["PandoraPFOs"],

"SimCaloHitCollections": [

"BeamCalCollection",

"LHCalCollection",

"LumiCalCollection",

CONSTANTS["ECalSimHitCollections"],

CONSTANTS["HCalSimHitCollections"],

"YokeBarrelCollection",

"YokeEndcapsCollection",

],

"SimCalorimeterHitRelationNames": [

"EcalBarrelRelationsSimRec",

"EcalEndcapRingRelationsSimRec",

"EcalEndcapsRelationsSimRec",

"HcalBarrelRelationsSimRec",

"HcalEndcapRingRelationsSimRec",

"HcalEndcapsRelationsSimRec",

"RelationLHcalHit",

"RelationMuonHit",

"RelationLcalHit",

"RelationBCalHit",

],

"SimTrackerHitCollections": [

"VXDCollection",

"SITCollection",

"FTD_PIXELCollection",

"FTD_STRIPCollection",

"TPCCollection",

"SETCollection",

],

"TrackCollection": ["MarlinTrkTracks"],

"TrackMCTruthLinkName": ["MarlinTrkTracksMCTruthLink"],

"TrackerHitsRelInputCollections": [

"VXDTrackerHitRelations",

"SITTrackerHitRelations",

"FTDPixelTrackerHitRelations",

"FTDSpacePointRelations",

"TPCTrackerHitRelations",

"SETSpacePointRelations",

],

"UseTrackerHitRelations": ["true"],

"UsingParticleGun": [str(using_particle_gun).lower()],

}

) and not in the ILDReconstruction.py. This is also already present in my fork. I guess it may make more sense to take the MCRecoTruthLinker from my fork?

Okay, yes that makes totally sense. Shall I remove the truth link stuff from this PR?

Victor-Schwan · 2026-08-12T13:52:51Z

Okay, yes that makes totally sense. Shall I remove the truth link stuff from this PR?

In my opinion, that makes the most sense. If you need it, just cherrypick it from my PR. This way, git is aware of it and there shouldn't be any conflicts later on

tmadlener · 2026-08-13T09:42:01Z

So for clarification: This PR will introduce the vertex resolution setting bits and #193 will do the truth linking?

tmadlener · 2026-08-13T09:44:02Z

+    "ResolutionU": [str(x) for x in VXDBarrelDigitiserResolutionU],
+    "ResolutionV": [str(x) for x in VXDBarrelDigitiserResolutionV],


This will not be the same inputs as before, as the globals only have one number, so the result of this will be

"ResolutionU": ["0.003"],

Will this result in a simple "broadcast" to all layers or do we have to make sure that we still have the right number of elements in the resulting list?

tmadlener · 2026-08-13T09:44:49Z

 from py_utils import encode_CT_steps_dict_to_legacy_list

-CT_MAX_DIST = "0.03"  # RANDOM VALUE COPYIED FROM CLDRECO
+CT_MAX_DIST = "0.05"  # RANDOM VALUE COPYIED FROM CLDRECO


Is the comment still valid then? I.e. is this just another random value copied from CLDRECO? If not we should update the comment that it's now a better informed choice.

tmadlener · 2026-08-13T09:46:47Z

+    "LowerCellAngle2": {
+        "collections": [""],
+        "params": {
+            "MaxCellAngle": 0.1,
+            "MaxCellAngleRZ": 0.1,
+            "Chi2Cut": 2000,
+            "MinClustersOnTrack": 4,
+            "MaxDistance": CT_MAX_DIST,
+            "SlopeZRange": 10.0,
+            "HighPTCut": 10.0,
+        },
+        "flags": ["HighPTFit", "VertexToTracker", "RadialSearch"],
+        "functions": ["BuildNewTracks","SortTracks"],
+    },


This additional conformal tracking pass seems to not be mentioned in the discussion of the PR. I assume it's deliberately enabled. Can we put a short sentence about this into the release notes?

Victor-Schwan · 2026-08-13T09:48:10Z

So for clarification: This PR will introduce the vertex resolution setting bits and #193 will do the truth linking?

There are many things in #193 that are necessary for FCC tracking. I've created a draft PR so that others can see it and, for example, to avoid implementing TruthLinking twice. However, it might make sense to merge TruthLinking beforehand in a separate PR. Let me know if you wish to do so

tmadlener · 2026-08-13T09:48:48Z

However, it might make sense to merge TruthLinking beforehand in a separate PR. Let me know if you wish to do so

That sounds like a good idea

Adding truth info for FCC-ee ILD model, add vertex resolutions as inp…

0422a8d

…ut arguments, update vertex detector naming scheme to be compliant also with FCC-SEED VXD (backwards compatible with CLD VXD), updating CT_MAX_DIST value to use the same as CLD with smaller beam pipe

armin-ilg mentioned this pull request Jul 20, 2026

Adding FCC-SEED as option to all detectors and refactor IDEA/ALLEGRO vertex detector key4hep/k4geo#612

Open

8 tasks

Victor-Schwan reviewed Jul 28, 2026

View reviewed changes

Comment thread StandardConfig/production/ILDReconstruction.py Outdated

Victor-Schwan reviewed Jul 28, 2026

View reviewed changes

Update StandardConfig/production/ILDReconstruction.py

303def9

Co-authored-by: Victor Schwan <162138084+Victor-Schwan@users.noreply.github.com>

tmadlener reviewed Aug 13, 2026

View reviewed changes

		"ResolutionU": [str(x) for x in VXDBarrelDigitiserResolutionU],
		"ResolutionV": [str(x) for x in VXDBarrelDigitiserResolutionV],

Uh oh!

Conversation

armin-ilg commented Jul 20, 2026

Uh oh!

armin-ilg commented Jul 20, 2026

Uh oh!

Victor-Schwan Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Victor-Schwan Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Victor-Schwan Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Victor-Schwan commented Jul 28, 2026

Uh oh!

armin-ilg commented Aug 12, 2026

Uh oh!

Victor-Schwan commented Aug 12, 2026

Uh oh!

tmadlener commented Aug 13, 2026

Uh oh!

tmadlener Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

tmadlener Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

tmadlener Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

Victor-Schwan commented Aug 13, 2026

Uh oh!

tmadlener commented Aug 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants