Conversation
…rained prompt - Fix stdout pipe deadlock: change Stdio::piped() to Stdio::null() for render process stdout in section_video.rs and render.rs. The piped stdout was never consumed, causing the OS pipe buffer (64KB) to fill up and deadlock the Chrome render process. - Replace unwrap() calls in timeline.rs with safe match patterns to eliminate panic risk from TOCTOU race between has_audio check and frag_map lookup in concurrent batch generation. - Rewrite agent prompt: convert 6 negative constraints (禁止/不要/不能) to positive creative direction. Add role framing, restructure into clear sections (role, content, visuals, rhythm, technical), and move render engine requirements to a dedicated numbered list with rationale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rained prompt
Fix stdout pipe deadlock: change Stdio::piped() to Stdio::null() for render process stdout in section_video.rs and render.rs. The piped stdout was never consumed, causing the OS pipe buffer (64KB) to fill up and deadlock the Chrome render process.
Replace unwrap() calls in timeline.rs with safe match patterns to eliminate panic risk from TOCTOU race between has_audio check and frag_map lookup in concurrent batch generation.
Rewrite agent prompt: convert 6 negative constraints (禁止/不要/不能) to positive creative direction. Add role framing, restructure into clear sections (role, content, visuals, rhythm, technical), and move render engine requirements to a dedicated numbered list with rationale.