fix: make team creation API fields optional#681
Open
hyoseop1231 wants to merge 1 commit into
Open
Conversation
- Add missing `backend` field to `TeamAgentInputCompat` (was silently rejected by `deny_unknown_fields`)
- Make `model` optional with `#[serde(default)]`
- Make `assistant_id` optional in custom deserializer (was forced required)
Previously, POST /api/teams required both `model` and `assistant_id`
in every agent object, and silently rejected `backend` due to
`deny_unknown_fields` on the compat struct. This made the API
unusable from external clients that don't know the internal
assistant catalog.
Now clients can create teams with minimal payloads:
{"name":"t","agents":[{"name":"Bot","role":"lead","backend":"claude"}]}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
POST /api/teams returns Invalid JSON request body for any payload where agent objects omit model or assistant_id, and silently rejects backend due to deny_unknown_fields on TeamAgentInputCompat.
Fix (3 changes)