Bundle everything under data/, not just locale - #245
Merged
Conversation
The script copied data/locale and nothing else, so data/effects never reached
the bundle and the Tiles feature was dead on every macOS install. It said so
in the log and nothing was listening:
Tiles effect not found: effects/corevideo-tiles.effect is missing from
the plugin's data directory
Caught live 2026-09-05 on the first properly-signed macOS test build.
Same shape as the missing-engine bug fixed the same day: the script knew what
it needed and enumerated it BY HAND rather than copying what is actually there,
so anything added to data/ afterwards was silently dropped. Copying the
directory's contents means the next addition cannot repeat this.
obs_module_file() resolves to Contents/Resources on macOS, so the layout under
data/ carries over verbatim.
Verified: Resources/effects/corevideo-tiles.effect is present in a rebuilt
bundle, alongside Resources/locale/en-US.ini.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defect
scripts/make-macos-bundle.shcopieddata/localeand nothing else, sodata/effects/corevideo-tiles.effectnever reached the bundle. Tiles was dead on every macOS install.The plugin said so on every load and nothing was listening:
Caught live on 2026-09-05, on the first properly-signed macOS test build.
Why it happened
Same shape as the missing-engine bug fixed the same day (#244): the script knew what it needed and enumerated it by hand rather than copying what is actually there. Anything added to
data/afterwards was silently dropped.The change
Copy the contents of
data/rather than a hand-listed subset, so the next addition cannot repeat this.obs_module_file()resolves toContents/Resourceson macOS, so the layout carries over verbatim.Verification
Rebuilt bundle now contains both:
🤖 Generated with Claude Code