Fix macOS meeting and media recovery after soak testing - #253
Draft
iamfatness wants to merge 14 commits into
Draft
Fix macOS meeting and media recovery after soak testing#253iamfatness wants to merge 14 commits into
iamfatness wants to merge 14 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| static int failures = 0; | ||
| static void check(bool ok, const char *message) { | ||
| if (!ok) { std::fprintf(stderr, "FAIL: %s\n", message); ++failures; } |
|
|
||
| static int failures; | ||
| static void check(bool value, const char *message) { | ||
| if (!value) { std::fprintf(stderr, "FAIL: %s\n", message); ++failures; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoreVideo could flood the operator with subscription errors after recording permission was granted near a breakout transfer, leave the waiting room after two minutes, and keep a shared participant renderer at tile resolution when an HD source was added.
This change gives macOS raw media a single lifecycle owner, preserves desired bindings across room transitions, consolidates source failures into actionable media status, and makes Retry Media reach exhausted tile feeds. Waiting-room events now hold the existing admission watchdog. Director decisions clamp stale timestamps and log cut attribution. Shared video quality uses the highest current target request, upgrades the warm renderer in place, preserves it on refusal, and limits automatic quality retries to three.
Validation: full arm64 macOS plugin and engine build against Zoom SDK 7.1.5; 75/75 CTest tests passed, including a regression through real client event handling for breakout readiness. Individual task reviews and a combined review passed after corrections. Cross-platform GitHub checks are running on the final revision.
This remains a draft pending candidate validation. Host-controlled recording permission and breakout checks, actual HD delivery, a two-hour soak, and installation on a second Mac remain outstanding. The working beta release and website download remain unchanged. Missing ATEM audio hardware is a local OBS configuration item and is outside this change.