Upgrade IceRpc dependencies to 0.6.x#17
Merged
Merged
Conversation
- Update README example client links from 0.5.x to 0.6.x - Bump all IceRpc package references to 0.6.x and add IceRpc base package - Replace `[SliceService]`/`[ProtobufService]` with `[Service]` attribute - Switch Slice file attribute from `cs::namespace` to `cs::identifier`
- Remove `USE_TLS_WITH_TCP` env var; TCP always uses TLS now - Use explicit `serverAddressUri` for TCP and QUIC servers - Use named loggers instead of generic `Server` type - Simplify `.Map()` calls by removing explicit type arguments - Remove `IceRpc.Transports.Quic` using directive from server file
There was a problem hiding this comment.
Pull request overview
Updates this hello server sample to IceRpc 0.6.x APIs and package layout, aligning service annotations, Slice metadata, and server setup with the new release.
Changes:
- Bumped IceRpc NuGet dependencies to
0.6.*and added the baseIceRpcpackage. - Migrated service implementations from
[SliceService]/[ProtobufService]to[Service]and updated router mapping calls. - Updated Slice attributes from
cs::namespacetocs::identifierand refreshed README example client links to0.6.x(also removingUSE_TLS_WITH_TCPreferences).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/slice/Greeter.slice | Switch Slice C# attribute to cs::identifier for 0.6.x tooling. |
| src/slice/Generator.slice | Switch Slice C# attribute to cs::identifier for 0.6.x tooling. |
| src/Hello/Stream.Slice/RandomGenerator.cs | Update service attribute/namespace usage for 0.6.x ([Service]). |
| src/Hello/Stream.Protobuf/RandomGenerator.cs | Update service attribute/namespace usage for 0.6.x ([Service]). |
| src/Hello/Hello.csproj | Bump IceRpc package references to 0.6.* and add base IceRpc. |
| src/Hello/Hello.cs | Update router mapping and server construction to 0.6.x patterns; remove old QUIC transport wiring. |
| src/Hello/Greeter.Slice/Chatbot.cs | Update service attribute/namespace usage for 0.6.x ([Service]). |
| src/Hello/Greeter.Protobuf/Chatbot.cs | Update service attribute/namespace usage for 0.6.x ([Service]). |
| README.md | Refresh example client links to 0.6.x and remove USE_TLS_WITH_TCP documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bernardnormier
approved these changes
Jun 8, 2026
| @@ -1,6 +1,6 @@ | |||
| // Copyright (c) ZeroC, Inc. | |||
|
|
|||
| [cs::namespace("Hello.Greeter.Slice")] | |||
| [cs::identifier("Hello.Greeter.Slice")] | |||
Member
There was a problem hiding this comment.
We should move the Slice files to sub-dirs like in the examples.
| @@ -1,6 +1,6 @@ | |||
| // Copyright (c) ZeroC, Inc. | |||
|
|
|||
| [cs::namespace("Hello.Stream.Slice")] | |||
| [cs::identifier("Hello.Stream.Slice")] | |||
| module StreamExample | |||
pepone
approved these changes
Jun 8, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
- Move generator.proto to stream_example/ subdirectory - Move greeter.proto to visitor_center/ subdirectory - Move Generator.slice to StreamExample/ subdirectory - Move Greeter.slice to VisitorCenter/ subdirectory - Update comment in Hello.cs to mention RandomGenerator services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SliceService]/[ProtobufService]with[Service]attributecs::namespacetocs::identifier