Fix deleted messages remaining visible in chat#28
Open
TiaraBasori wants to merge 5 commits into
Open
Conversation
TiaraBasori
commented
Jul 12, 2026
TiaraBasori
left a comment
Contributor
Author
There was a problem hiding this comment.
Strict review found one remaining cache invalidation hole: mithkaChatHistoryCleared replaces messages and notifies listeners without advancing messageVersion, so _transcriptEntries can still reuse the old transcript when the list object/cache state lines up. I am patching this branch so every destructive transcript mutation invalidates the cache.
TiaraBasori
force-pushed
the
fix/delete-message-cache-stale
branch
from
July 12, 2026 04:21
f9c7f08 to
3d4e2cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invalidate the transcript memoization when messages are removed so deleted messages disappear immediately instead of remaining visible until the chat is reopened.
Root cause
The message list is mutated in place during deletion. Transcript caching only checked list identity, so it reused stale entries after the view model notified listeners.
Validation
flutter analyze lib/chat/chat_view.dart lib/chat/chat_view_model.dartgit diff --check