Skip to content

Format scripts#1145

Open
corentinravoux wants to merge 8 commits into
mainfrom
format_scripts
Open

Format scripts#1145
corentinravoux wants to merge 8 commits into
mainfrom
format_scripts

Conversation

@corentinravoux

Copy link
Copy Markdown
Contributor

Format all the scripts, correct errors from a linter and improve the consistency in the way the scripts are launched.

Copilot AI review requested due to automatic review settings June 3, 2026 09:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@corentinravoux

Copy link
Copy Markdown
Contributor Author

@andreicuceu @HiramHerrera Hey, while doing this formatting I found an issue in the picca_xcf.py script:
# Find the redshift range if args.z_min_obj is None: r_comov_min = cosmo.get_r_comov(z_min) r_comov_min = max(0.0, r_comov_min + xcf.r_par_min) args.z_min_obj = cosmo.distance_to_redshift(r_comov_min) userprint("z_min_obj = {}".format(args.z_min_obj), end="") if args.z_max_obj is None: r_comov_max = cosmo.get_r_comov(z_max) r_comov_max = max(0.0, r_comov_max + xcf.r_par_max) args.z_max_obj = cosmo.distance_to_redshift(r_comov_max) userprint("z_max_obj = {}".format(args.z_max_obj), end="")
On this part (which coresponds to lines 390-400 in my branch, the z_min and z_max used here is not defined before, is it link to the recent PR that you pushed ? Right now I am unsure how to solve it, is z_min_obj used a lot ?

@corentinravoux

Copy link
Copy Markdown
Contributor Author

@julienguy This PR is done to answer the issue you raised regarding script structure

@corentinravoux

Copy link
Copy Markdown
Contributor Author

@andreicuceu @HiramHerrera I do not know if you have seen the comment above ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants