(MOT-4443) fix(console): recover router presence after reconnect - #810
(MOT-4443) fix(console): recover router presence after reconnect#810ytallo wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
skill-check — worker0 verified, 60 skipped (no docs/).
Four for four. Nicely done. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Root cause
The Console could miss the router arrival event while its browser WebSocket was disconnected. Because the presence watcher remained absent, the model picker stayed disabled after reconnecting. A present-to-present router replacement also kept the same boolean state, so router-owned subscriptions were not necessarily rebuilt.
Impact
The model picker can recover without reloading the page when the router starts during a browser connection outage or when the router process is replaced. Transient fetch failures preserve the last confirmed catalog while successful empty responses still clear it.
Testing
pnpm test: 1,213 tests passedpnpm run typecheckpnpm run typecheck:e2ebash -n harness/tests/quickstart/run-ci.shgit diff --checkThe provider-backed quickstart scenarios were not executed end-to-end because they require a dedicated live stack and provider credentials.
Stacked on #808 and targets its head branch.
Refs MOT-4443