(MOT-3732) feat(security-scan): add scan controls and GitHub remediation - #826
Open
rohitg00 wants to merge 5 commits into
Open
(MOT-3732) feat(security-scan): add scan controls and GitHub remediation#826rohitg00 wants to merge 5 commits into
rohitg00 wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
skill-check — worker0 verified, 62 skipped (no docs/).
Four for four. Nicely done. |
…and drop every UI timer The page could not choose a model. It read the open chat composer on a 750ms interval and sent whatever it found, so a scan started from a standalone security-scans tab silently fell back to the operator default, and a composer left on a weak model quietly decided the review. The sidebar now lists the live router catalog. Selecting an entry pins that model for the scan; `follow chat` keeps the previous behavior and is still the default. A pinned model that leaves the catalog reverts to following rather than sending an id the router no longer serves. The catalog is re-read on the router's own `router::models::changed` fan-out, so a credential added or a provider removed updates the list without a reload. The same pass removes the page's remaining timers. Run updates already arrive on the `security-scan:runs` doorbell; the 2s/10s/30s sweep behind it is gone, and the list now re-reads on the doorbell, on reconnect, on the tab becoming visible, and on the refresh control. The action store drops its bounded fallback reads for the same reason, and the analysis-chat follow drops its 750ms retry: the `session::created` binding it already held is the only other thing that can change the answer. A configure control opens the console's own worker-configuration dialog for the analysis budgets (`max_turns` and the token and cost ceilings), the operator model, and the repository allowlist. It is read off `host.components` at runtime, so a console predating that export degrades to navigation instead of failing the module load.
…curity-scan-live-model-picker # Conflicts: # security-scan/README.md # security-scan/ui/src/page/index.tsx # security-scan/ui/src/page/useSecurityRunsLive.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixes MOT-3732
Stacked on #807. Uses optional Console host chat APIs from #823. Calls existing github worker functions; no github/ source changes.