test: validate n8n workflow compatibility - #60
Open
adnqcr7-code wants to merge 1 commit into
Open
Conversation
ikaruscareer
approved these changes
Aug 17, 2026
ikaruscareer
left a comment
ikaruscareer
left a comment
Owner
There was a problem hiding this comment.
Parser fix is critical, thanks. The nested connection-array shape fix addresses a real-world parsing gap that would cause false negatives in production scans.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def test_representative_n8n_fixture_has_no_credential_values_or_private_endpoints(): | ||
| workflow_path = os.path.join(FIXTURE, "workflow.json") | ||
| workflow_text = open(workflow_path, encoding="utf-8").read() |
Owner
There was a problem hiding this comment.
Some CI checks were not successful, "Ruff's SIM115 rule enforces proper file handle management".
@adnqcr7-code, can you please consider suggestion of using "with" keyword:
with open(workflow_path, encoding="utf-8") as f:
workflow_text = f.read()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a deterministic representative n8n workflow fixture and integration coverage for framework detection, workflow and node extraction, relationships, external APIs, databases, shell execution, and AI-model capabilities.
Also fix the n8n parser to handle the nested connection-array shape emitted by n8n exports.
Safety
The fixture uses a synthetic model and a placeholder credential reference only. It contains no tokens, passwords, private data, or live endpoints.
Test plan
python -m pytest tests/test_n8n_workflow.py -qpython -m pytest tests/test_claude_code_deep.py -qpython -m pytest tests -qFixes #56