postprocess: Tighten model input handling#1852
Closed
Crocodoctopus wants to merge 1 commit into
Closed
Conversation
thedataking
reviewed
Jun 12, 2026
| except KeyboardInterrupt: | ||
| logging.warning("Interrupted by user, terminating...") | ||
| return 130 # 128 + SIGINT(2) | ||
| except ValueError as error: |
Contributor
There was a problem hiding this comment.
this seems unrelated to key handling; please remove
thedataking
reviewed
Jun 12, 2026
| return os.getenv("OPENAI_API_KEY") | ||
| return None | ||
|
|
||
| raise ValueError(f"Unsupported model identifier: {model_id}") |
Contributor
I don't know what that would buy us.
What specifically was wrong with the current approach? |
Contributor
|
I don't think we want this change. Please try #1853 and see if that unblocks GaloisInc/Tractor-Crisp#131. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds guards for model selection, as well as cleans up an env read that happened deeper than it needed to; env reading now happens in init and is passed down.
I think it wouldn't be a bad idea to combine
GEMINI_API_KEYwithOPENAI_API_KEYhere too, but it would depend on what else uses this API already.